make IconColumn and IconEntry support collections #11991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guess the changes introduced an error.
|
|
That's super weird, I released .60 to fix. I think its a Blade compilation bug |
|
Yeah really odd. Can u push the release tag? |
|
I did, its just not a GitHub release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
IconColumnand theIconEntrydoesn't support collections as state as theText*equivalents does. This PR wraps the state into a Collection instead of an array.Having a Collection is a common use case, when one has an
AsEnumCollection::classcast on a model with an enum implementing theHasIconinterface .Visual changes
Before:
After:
Functional changes
composer cscommand.