BugFix: Import Action Look at File System Disk Driver for s3 #12095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danharrin
reviewed
Mar 29, 2024
|
Happy to see this fix. We ran into this a few weeks ago and just haven't had the bandwidth to try to address it via PR. Thx, @mmccall10 and @danharrin ! 🤓 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a filesystems disk name is not s3 the import action fails with
fopenregardless ofFILAMENT_FILESYSTEM_DISKandFILESYSTEM_DISKbeing set to the s3 driver. This PR changes the lookup to check the driver of the configured disks vs the name.Visual changes
N/A
Functional changes
composer cscommand.