Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to remove topbar from the profile page #12515

Merged
merged 3 commits into from Apr 29, 2024

Conversation

saade
Copy link
Member

@saade saade commented Apr 26, 2024

Description

Every auth page has an option to remove the topbar except for the profile page. This PR adds the same configuration option as the other pages.

@saade saade requested a review from danharrin April 26, 2024 21:37
@danharrin danharrin added the enhancement New feature or request label Apr 28, 2024
@danharrin danharrin added this to the v3 milestone Apr 28, 2024
Copy link
Member

@danharrin danharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

@danharrin danharrin self-assigned this Apr 28, 2024
@saade
Copy link
Member Author

saade commented Apr 28, 2024

@danharrin Done. Took a step further and extracted $hasMaxWidth too. Feel free to revert it.

@saade saade requested a review from danharrin April 28, 2024 21:50
@danharrin danharrin merged commit 1adc74d into 3.x Apr 29, 2024
21 checks passed
@danharrin
Copy link
Member

Thanks!

@danharrin danharrin deleted the feat/profile-page-topbar branch April 29, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants