Update CanBeHidden traits for a more consistent implementation everywhere #1383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed that the
CanBeHidden
traits do not share the same implementation everywhere. For example, I wanted to dynamically determine whether to displayButtonAction
A or B.To fix that, I copied over the IMO best implementation of
CanBeHidden
, which is the implementation that offers both thehidden()
andvisible()
methods.For the page actions there wasn't a way to evaluate closures yet, so I added an
EvaluatesClosures
trait as well for the page actions. I saw that a page action also had aBelongsToLivewire
trait that exposes agetLivewire()
method. I used that method to add a$livewire
parameter to theEvaluatesClosures
trait. I couldn't think of a use case for that, but I though that it couldn't do any harm either.