extract create modal actions

[wychoong]

No description provided.

[danharrin]

Method names like getCancelModalAction() aren't appropriate for traits like this, as there are many cancel actions on the class. Prefix each method name with getCreateAction, so getCreateActionCancelModalAction() or similar. Also, do you need to do the same for CanAttachRecords?

[wychoong]

Method names like getCancelModalAction() aren't appropriate for traits like this, as there are many cancel actions on the class. Prefix each method name with getCreateAction, so getCreateActionCancelModalAction() or similar. Also, do you need to do the same for CanAttachRecords?

Will look into both.

Actually the purpose of extracting is I want to remove createAndCreateAnother. Do you think it would be better to:

• a config to disable createAndCreateAnother globally
• Add prepend/append form actions method (if not available yet)

[danharrin]

How about config('filament.resources.have_create_and_create_another_actions')?

[MACscr]

global options are great, but i would also like to be able to set this per resource as well.

[wychoong]

Prefix each method name with getCreateAction,

this will result to

$this->getCreateActionCreateModalAction(),
$this->getCreateActionCreateAndCreateAnotherModalAction(),
$this->getCreateActionCancelModalAction(),

is that ok?

[danharrin]

Prefix each method name with getCreateAction,

this will result to

$this->getCreateActionCreateModalAction(),
$this->getCreateActionCreateAndCreateAnotherModalAction(),
$this->getCreateActionCancelModalAction(),

is that ok?

Yup that's fine

[wychoong]

Prefix each method name with getCreateAction,

this will result to

$this->getCreateActionCreateModalAction(),
$this->getCreateActionCreateAndCreateAnotherModalAction(),
$this->getCreateActionCancelModalAction(),

is that ok?

Yup that's fine

the PR is ready, it's now is more than just extracting modal actions 😅 but it's to make resource actions consistent with RM.

one part I'm not sure is it the best to set the static property globally with FilamentManager and RelationManager

[danharrin]

Thanks. I have simplified this a bit, mostly by removing the facade option. I've also moved a couple of the static methods onto the trait instead of the relation manager, which means you need to disable these actions for each type of relation manager instead of all at once. This just helps us keep the maintenance overhead for this feature low.