Added trim functionality to Text Column

[jamessessford]

Morning folks,

TLDR: Added trim functionality to Text Column

I found that I was using the getValueUsing callback a lot of the time just to trim the length of the content but if I did this I lost the ability to search or sort on that field.

I've added a trim helper to the Text column that takes a trim length and then trims the value after it's been taken from the record.

Example usage:

Columns\Text::make('reference')->primary()->searchable()->sortable()->trim(6),

This allows me to only show the first six characters of the reference in the table but retain search and sort functionality.

Cheers!

[danharrin]

Hey James! This sounds like a job for formatUsing rather than getValueUsing. We should use the trim() method to set that callback, similar to date(). Let me know how that goes.

[ryangjchandler]

I think this method should probably be called truncate or limit, since PHP's trim function is for removing characters at each end, not actually limiting the length of a string.

[jamessessford]

Totally agreed @ryangjchandler - Updating now

[jamessessford]

I've changed the function to limit rather than trim (that was the str helper it's piggybacking) and updated to use formatUsing rather than getValueUsing.

Cheers!