Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow uploaded images to s3 with private visibility to load #157

Merged
merged 4 commits into from
Mar 10, 2021
Merged

fix: allow uploaded images to s3 with private visibility to load #157

merged 4 commits into from
Mar 10, 2021

Conversation

tomheno
Copy link
Contributor

@tomheno tomheno commented Mar 10, 2021

This pull request is aimed to fix the behavior described in #156.

With file visibility detection
packages/forms/src/HasForm.php Outdated Show resolved Hide resolved
packages/forms/src/HasForm.php Outdated Show resolved Hide resolved
packages/tables/src/Columns/Image.php Outdated Show resolved Hide resolved
Co-authored-by: Ryan Chandler <ryangjchandler@gmail.com>
@danharrin danharrin marked this pull request as ready for review March 10, 2021 13:51
@danharrin danharrin added the bug Something isn't working label Mar 10, 2021
@danharrin danharrin merged commit 9035892 into filamentphp:develop Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants