Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow customization for BelongsToSelect label #1658

Merged
merged 8 commits into from
Mar 2, 2022
Merged

feat: Allow customization for BelongsToSelect label #1658

merged 8 commits into from
Mar 2, 2022

Conversation

pxlrbt
Copy link
Member

@pxlrbt pxlrbt commented Feb 18, 2022

As discussed on Discord this allows to easily set a label for the BelongsToSelect without overwriting the whole getSearchResultsUsing() and getOptionLabelUsing() callbacks.

Outlook
This could also applied to BelongsToManyMultiSelect and BelongsToManyCheckboxList . Both are missing the searchable() method or $searchColumns property this feature relies on. While it makes sense to add this to BelongsToManyMultiSelect there is no search on BelongsToManyCheckboxList and we need to define the fields for the SELECT statement differently.

@pxlrbt pxlrbt changed the title feat: Allow customization for BelongsToSelect label [DRAFT] feat: Allow customization for BelongsToSelect label Feb 18, 2022
@pxlrbt pxlrbt changed the title [DRAFT] feat: Allow customization for BelongsToSelect label feat: Allow customization for BelongsToSelect label Feb 18, 2022
@danharrin danharrin added the enhancement New feature or request label Feb 24, 2022
@danharrin danharrin merged commit 67d4b4c into filamentphp:2.x Mar 2, 2022
@danharrin
Copy link
Member

Thanks!

@pxlrbt
Copy link
Member Author

pxlrbt commented Mar 2, 2022

Thanks for your additions and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants