feat: Allow customization for BelongsToSelect label #1658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discord this allows to easily set a label for the BelongsToSelect without overwriting the whole
getSearchResultsUsing()
andgetOptionLabelUsing()
callbacks.Outlook
This could also applied to
BelongsToManyMultiSelect
andBelongsToManyCheckboxList
. Both are missing thesearchable()
method or$searchColumns
property this feature relies on. While it makes sense to add this toBelongsToManyMultiSelect
there is no search onBelongsToManyCheckboxList
and we need to define the fields for the SELECT statement differently.