Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new table widget type #1813

Merged
merged 12 commits into from
Mar 8, 2022
Merged

Add a new table widget type #1813

merged 12 commits into from
Mar 8, 2022

Conversation

jacksleight
Copy link
Contributor

@jacksleight jacksleight commented Mar 7, 2022

Adds a new type of widget called TableWidget. Simply implements InteractsWithTable and outputs the result.

Includes a new --T|table option to the make:filament-widget command.

Example (with pagination disabled):

Screenshot 2022-03-07 at 10 44 39

packages/admin/stubs/TableWidget.stub Outdated Show resolved Hide resolved
packages/admin/stubs/TableWidget.stub Outdated Show resolved Hide resolved
@ryangjchandler
Copy link
Member

@jacksleight This is a great idea I think, assuming @danharrin agrees, would you be able to add this to the docs too?

@jacksleight
Copy link
Contributor Author

Added a new section to the docs.

Is there any reason why the docs dont tell you to use the --stats-overview and --chart etc. flags on make:filament-widget?

@danharrin danharrin added the enhancement New feature or request label Mar 7, 2022
@danharrin
Copy link
Member

Those command flags are relatively new so haven't been documented yet.

@ryangjchandler
Copy link
Member

Ignore that last comment - GH showed me an old commit from the notifications, lol.

@danharrin
Copy link
Member

Maybe we should also use ->beforeLast('Widget') on the heading? Don't we do the same for chart widgets?

@danharrin danharrin merged commit 47f2929 into filamentphp:2.x Mar 8, 2022
@danharrin
Copy link
Member

Thanks!

@jacksleight jacksleight deleted the table-widget branch March 9, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants