Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Tippy CSS as dependency for collapsible sidebar #2018

Merged
merged 5 commits into from
Apr 7, 2022
Merged

Clarify Tippy CSS as dependency for collapsible sidebar #2018

merged 5 commits into from
Apr 7, 2022

Conversation

ralphjsmit
Copy link
Contributor

Proposal for adding Tippy CSS dependency to the appearance page.

Have a good weekend!

pxlrbt
pxlrbt requested changes Mar 25, 2022
View reviewed changes
Copy link
Member

@pxlrbt pxlrbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For dark mode there's also the light theme required.

packages/admin/docs/07-appearance.md Outdated Show resolved Hide resolved
packages/admin/docs/07-appearance.md Outdated Show resolved Hide resolved
ralphjsmit and others added 2 commits March 25, 2022 16:03
@ralphjsmit @pxlrbt
Update packages/admin/docs/07-appearance.md
a5dbd9b 
Co-authored-by: Dennis Koch <info@pixelarbeit.de>
@ralphjsmit @pxlrbt
Update packages/admin/docs/07-appearance.md
cbf8628 
Co-authored-by: Dennis Koch <info@pixelarbeit.de>
@ralphjsmit
Copy link
Contributor Author

For dark mode there's also the light theme required.

Committed your suggested changes, thanks!

@ryangjchandler
Copy link
Member

Should we not be compiling the Tippy CSS into the admin CSS?

@pxlrbt
Copy link
Member

pxlrbt commented Mar 25, 2022

We do. This is for people using their own theme.
My suggestion would be to separate general theme and vendor themes.

@ryangjchandler
Copy link
Member

Ah, my bad. Only saw feed from emails!

@danharrin danharrin added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 29, 2022
@danharrin danharrin merged commit 4393aaf into filamentphp:2.x Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxlrbt pxlrbt pxlrbt requested changes

@danharrin danharrin danharrin left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ralphjsmit @ryangjchandler @pxlrbt @danharrin