Laravel Octane Support: Scoped service binding #2055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2010
@danharrin As I was working on this I found there is an issue with octane itself where scoped services aren't being flushed correctly because of a discrepancy between octane and laravel itself. laravel/octane#500
There is a workaround where after this pull request is submitted you can add the filament service to octane's flush services in the config like so:
config/octane.php:
Is that something that should be added to the documentation or do you want to just refer people here? Once the issue in the octane package is resolved we won't need to add that item to the flush in the config