set TagsInput webkit-calendar-picker icon to 0 opacity #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is per discussion at #2067 Maybe we should add back in a SVG icon, but for now just having that weird hard to debug icon out is IMO a good thing. I sort of agree on the datalist thing which is why I created an issue before doing that. My only hesistation on the datalist is other unknown bugs, but we could get that with either solution. |
|
For some reason display:none didn't seem to work, it would obviously be the ideal solution here. |
danharrin
reviewed
Apr 3, 2022
| @@ -42,7 +42,7 @@ | |||
| x-on:blur="createTag()" | |||
| x-model="newTag" | |||
| {{ $getExtraInputAttributeBag()->class([ | |||
| 'block w-full border-0', | |||
| 'tags-input block w-full border-0', | |||
There was a problem hiding this comment.
Lets stick with utility classes and rename this webkit-calendar-picker-indicator-opacity-0 maybe?
danharrin
reviewed
Apr 3, 2022
| @@ -42,7 +42,7 @@ | |||
| x-on:blur="createTag()" | |||
| x-model="newTag" | |||
| {{ $getExtraInputAttributeBag()->class([ | |||
| 'block w-full border-0', | |||
| 'tags-input block w-full border-0', | |||
There was a problem hiding this comment.
Lets stick with utility classes and rename this webkit-calendar-picker-indicator-opacity-0 maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes webkit-calendar-picker icon on tagsinput
before:
after:
I did not like that I had to add another css file for this. Also don't love all the auto generated files in this commit.