Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve editor preview when using ViewRecord #2075

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Improve editor preview when using ViewRecord #2075

merged 2 commits into from
Apr 4, 2022

Conversation

mohamedsabil83
Copy link
Contributor

No description provided.

@danharrin danharrin added the ui label Apr 1, 2022
@danharrin
Copy link
Member

Can you provide before and after screenshots please?

@mohamedsabil83
Copy link
Contributor Author

Before
Screenshot from 2022-04-01 21-54-31

After
Screenshot from 2022-04-01 21-54-55

@mohamedsabil83
Copy link
Contributor Author

In fact, it's a ui fix including dark mode

@mohamedsabil83 mohamedsabil83 changed the title Improve content preview on dark mode Improve editor preview when using ViewRecord Apr 1, 2022
@ryangjchandler ryangjchandler added the enhancement New feature or request label Apr 1, 2022
@danharrin danharrin merged commit 3d15313 into filamentphp:2.x Apr 4, 2022
@danharrin
Copy link
Member

Thanks!

@mohamedsabil83
Copy link
Contributor Author

Welcome!

@mohamedsabil83 mohamedsabil83 deleted the ui/editor-preview-improvements branch April 4, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mohamedsabil83 @danharrin @ryangjchandler