Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Page Title Improvement #2084

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

intrepidws
Copy link
Contributor

This PR makes the formatting of the title for the view page consistent with the formatting of the title for the create and edit pages. For the examples below, let's assume we have a Registrant Record with a title of Craig Anderson. Currently, the page titles for these three pages would be as follows:

  • Create Page: Create Registrant
  • Edit Page: Edit Craig Anderson
  • View Page: Craig Anderson

I found this to be confusing for the user experience, especially in situations when some resources have a View page only, some have an Edit page only, and some have both.

This PR changes the View page to be consistent with the formatting of the other two, as follows:

  • Create Page: Create Registrant
  • Edit Page: Edit Craig Anderson
  • View Page: View Craig Anderson

@danharrin danharrin added the enhancement New feature or request label Apr 4, 2022
@danharrin
Copy link
Member

Wow... you went into the effort to do this for every language? I have to applaud you. Thank you so much.

@danharrin danharrin merged commit f0245ed into filamentphp:2.x Apr 4, 2022
@intrepidws intrepidws deleted the view-page-title-improvement branch April 5, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants