New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: RichEditor spacing when no buttons #2529
Fix: RichEditor spacing when no buttons #2529
Conversation
packages/forms/resources/views/components/rich-editor.blade.php
Outdated
Show resolved
Hide resolved
Does this also fix the toolbar overflow issues here? #2514 I assume it does, with the |
Something seems off here, looks like I have merged the wrong classes 🤦♂️ I'm not sure about the related issue. |
Can't we just wrap the toolbar in an |
Much better solution 🤦♂️ |
Yeah thats fine, lets use |
Btw, this entire issue is Chrome-only 😅 Safari wins for once |
Also fixed #2514 Thanks John! |
Cheers Dan, sorry to leave you hanging there - I'm full-time Dadding at the mo. |
No worries John! :) |
When there are no buttons the toolbar
->disableAllToolbarButtons()
- the bar still shows, causing an extra line.Before
After
This conditionally hides the bar is no buttons.
Please let me know if you prefer a different syntax for the conditional class.