Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): remove duplicate display properties and use flex #2749

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

MaximeWillinger
Copy link
Contributor

This PR fixes an issue on the app.blade.php layout.
Two different CSS display properties were applied with hidden and flex. This was ambiguous.

Also, the custom x-cloak behaviour was implemented using !block instead of !flex.
Using !flex here allows to make custom pages's root element full height using h-full.

@danharrin danharrin added bug Something isn't working ui labels Jun 13, 2022
@danharrin danharrin merged commit bd004a4 into filamentphp:2.x Jun 13, 2022
@danharrin
Copy link
Member

Because some people have custom themes, this was causing the page content not to display at all on the page when it was loading (as the !flex class didnt exist in their CSS).

I don't class it as a breaking change as we recommend people recompile their themes after updating, but so many people forget and will report this as their entire admin panel "broken" so I have reverted this PR.

Instead, I've removed the conditional class and hidden, and just made it flex by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants