Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Polish language for v2.13 #2765

Merged
merged 4 commits into from Jun 15, 2022
Merged

Prepare Polish language for v2.13 #2765

merged 4 commits into from Jun 15, 2022

Conversation

kamilst96
Copy link
Contributor

Changes:

  • SoftDeletes & Wizard support.
  • Changed "Ładowanie..." to "Wczytywanie...". Seems more appropriate.
  • [?] Move from action & action another to action & continue for consecutive actions.
  • [?] Made a few changes to action result messages.

@lolen will you have a moment to review? Let's keep it as draft until review or until v2.13.

@danharrin danharrin added enhancement New feature or request i18n labels Jun 14, 2022
@lolen
Copy link
Contributor

lolen commented Jun 14, 2022

I'm worried about is returns:

  • Rekord utworzony
  • Rekord usunięty
  • Rekord przywrócony

They only concern a single record. I don't know if multiple records can be selected. And this is universal:

  • Utworzono
  • Usunięto
  • Przywrócono

[?] Move from action & action another to action & continue for consecutive actions.

Another concern I have is that "Continue" may be difficult for the user to read. And in the original it is "Create & create another" and the user knows what the next action is.

The rest without complaint. Great job.

@kamilst96
Copy link
Contributor Author

@lolen I was expecting push back on these, hence the question marks. Reverted both.

Rekord utworzony - I am not aware of being able to create more than one object at once. Rekord usunięty and Rekord przywrócony also have plural forms Rekordy usunięte and Rekordy przywrócone. It depends on whether single or multiple index is used. At least that's what I'm thinking.

@kamilst96 kamilst96 marked this pull request as ready for review June 15, 2022 12:47
@kamilst96
Copy link
Contributor Author

@danharrin I marked it by accident, but I think it's alright. @lolen ?

@danharrin danharrin merged commit c26ee37 into filamentphp:2.x Jun 15, 2022
Copy link
Contributor

@lolen lolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@kamilst96 kamilst96 deleted the fix/pl-lang-v2.13 branch June 15, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants