Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add useful info to new about command #3176

Merged
merged 6 commits into from
Jul 24, 2022

Conversation

ryangjchandler
Copy link
Member

Should be backwards compatible with the class_exists check.

Replaces #2869.

@ryangjchandler ryangjchandler added the enhancement New feature or request label Jul 19, 2022
@pxlrbt pxlrbt mentioned this pull request Jul 19, 2022
@danharrin
Copy link
Member

Also you should bump the min Laravel version

@pxlrbt
Copy link
Member

pxlrbt commented Jul 19, 2022

Also you should bump the min Laravel version

Don't think this is necessary:

Should be backwards compatible with the class_exists check.

@danharrin
Copy link
Member

yeah but maybe we should still do that so more people have access to it

@pxlrbt
Copy link
Member

pxlrbt commented Jul 19, 2022

As we currently also support L8, I think we should keep it that way. If we were on L9 already, I guess it would be okay.

@danharrin
Copy link
Member

Thats not what I mean, we can bump the Laravel 9 only version so L8 users can still use it

@danharrin
Copy link
Member

It just forces current L9 users to upgrade Laravel at the same time as Filament

@ryangjchandler
Copy link
Member Author

I'd say leave as is.

@pxlrbt
Copy link
Member

pxlrbt commented Jul 19, 2022

I guess that would be fine.

@ryangjchandler ryangjchandler force-pushed the feature/about-command-extension branch from f42dbf2 to 0186d0c Compare July 19, 2022 20:25
@zepfietje
Copy link
Member

It would be possible that a user has different versions installed for the forms/tables packages if installed separately from filament/filament, right?

Not sure how often that happens, but it might be useful to show the versions per package. What do you think?

@danharrin
Copy link
Member

No, we use self.version so all packages have the same version

@zepfietje
Copy link
Member

No, we use self.version so all packages have the same version

Even if you manually install just the forms and tables package? What about when pinning those to a specific version?

@danharrin
Copy link
Member

As far as I know there isnt a way around it

@danharrin danharrin merged commit 7e54a7d into 2.x Jul 24, 2022
@danharrin
Copy link
Member

Fixed it all, thanks @ryangjchandler

@danharrin danharrin deleted the feature/about-command-extension branch July 24, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants