Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Replicate action on EditRecord not working #3210

Merged
merged 3 commits into from
Jul 24, 2022
Merged

Fix: Replicate action on EditRecord not working #3210

merged 3 commits into from
Jul 24, 2022

Conversation

blite
Copy link
Contributor

@blite blite commented Jul 23, 2022

Adding a replicate button on an Edit page was not working properly. It appears the reason is that 'record' was not being passed in.

Example of how I tested this in demo app:

filamentphp/demo@main...blite:filament-demo:main

I also caught a bug in excludeAttributes documentation.

@blite blite changed the title Fixes Replicate action on EditRecord not working Fix: Replicate action on EditRecord not working Jul 23, 2022
@danharrin
Copy link
Member

Thanks! Ended up implementing a different fix for the missing $record, although yours did work

@danharrin danharrin merged commit 8fe7fec into filamentphp:2.x Jul 24, 2022
@danharrin danharrin added bug Something isn't working documentation Improvements or additions to documentation labels Jul 24, 2022
@blite blite deleted the fix-replicate branch July 25, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants