Enhancement: Sidebar open/close classes #3855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… open/closed state
|
Why move custom classes to middle or end of classes list? |
|
Weird. those shouldn't have changed. Let me see what happened. Good catch. |
|
Looks like there was an extension overriding the sort order. Latest push corrects the order. |
Thanks for noticing this! (Always nice to have an extra pair of eyes making sure the order stays correct in the codebase. 👀) |
zepfietje
requested changes
Sep 4, 2022
packages/admin/resources/views/components/layouts/app.blade.php
Outdated
Show resolved
Hide resolved
packages/admin/resources/views/components/layouts/app/sidebar/index.blade.php
Outdated
Show resolved
Hide resolved
packages/admin/resources/views/components/layouts/app/sidebar/index.blade.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Zep Fietje <hey@zepfietje.com>
…index.blade.php Co-authored-by: Zep Fietje <hey@zepfietje.com>
zepfietje
requested changes
Sep 4, 2022
packages/admin/resources/views/components/layouts/app/sidebar/index.blade.php
Outdated
Show resolved
Hide resolved
zepfietje
reviewed
Sep 4, 2022
packages/admin/resources/views/components/layouts/app.blade.php
Outdated
Show resolved
Hide resolved
zepfietje
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds classes to sidebar and filament main to allow css targeting of sidebar open/closed state