Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: MakeField command #39

Merged
merged 12 commits into from
Mar 2, 2021
Merged

feature: MakeField command #39

merged 12 commits into from
Mar 2, 2021

Conversation

ryangjchandler
Copy link
Member

This PR adds a new make:filament-field command.

It will generate a new Field class inside of Filament\Fields as well as a view in filament.fields.

Not sure what sort of boilerplate you want the stubs to have, so I went with the bare minimum. A $view property and an empty <div> in the view.

@ryangjchandler ryangjchandler marked this pull request as ready for review March 2, 2021 11:54
@danharrin
Copy link
Member

danharrin commented Mar 2, 2021

Maybe the view should be a field group, containing an empty Alpine component that entangles value to $formComponent->name?

@ryangjchandler
Copy link
Member Author

Maybe the view should be a field group, containing an empty Alpine component that entangles value to $formComponent->name?

Yeah good shout!

@danharrin danharrin merged commit 04bb9a6 into filamentphp:main Mar 2, 2021
@danharrin
Copy link
Member

Thanks

@danharrin danharrin added the enhancement New feature or request label Mar 2, 2021
@ryangjchandler ryangjchandler deleted the feature/make-field-command branch March 2, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants