Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing return in Text::getValue #46

Merged
merged 2 commits into from
Mar 2, 2021
Merged

fix: add missing return in Text::getValue #46

merged 2 commits into from
Mar 2, 2021

Conversation

ryangjchandler
Copy link
Member

This fixes an issue where the default value for a Text column wasn't being returned, purely a missing return statement.

@ryangjchandler
Copy link
Member Author

@danharrin I've also wrapped it in a value() call which means you can use a Closure to generate the default value.

@danharrin danharrin merged commit 05c1bc4 into filamentphp:main Mar 2, 2021
@ryangjchandler ryangjchandler deleted the fix/column-default-value branch March 2, 2021 14:13
@danharrin
Copy link
Member

LGTM!

@danharrin danharrin added bug Something isn't working enhancement New feature or request labels Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryangjchandler @danharrin