Allow for restricted domains #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryangjchandler
requested changes
Mar 2, 2021
config/filament.php
Outdated
| */ | ||
|
|
||
| 'path' => 'admin', | ||
|
|
||
| 'domain' => '', |
There was a problem hiding this comment.
I'd add a comment above the config option, like the path one above.
There was a problem hiding this comment.
Also, I think it might make sense to allow using an env() here too, that way you could change the domain based on staging, production, local, etc.
There was a problem hiding this comment.
@ryangjchandler yes I agree, I updated my PR
|
@jeroenvanrensen Should the default value be null instead of an empty string? |
|
Thank you! |
|
@ryangjchandler I tested it with an empty string and it worked, so I don't think so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, I have to say I absolutely love Filament! I really like the syntax and the ease of use.
I would like to use Filament only on a specific domain, so I created this PR.
This PR allows anyone to select a domain, and only from this domain Filament will be usable. All other domains will throw a 404 errorr.
If a user leaves the option empty, all domains will be allowed.
Thank you!
Jeroen