Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Rich editor dialog styles #5216

Merged
merged 2 commits into from
Dec 10, 2022
Merged

Fix: Rich editor dialog styles #5216

merged 2 commits into from
Dec 10, 2022

Conversation

awcodes
Copy link
Contributor

@awcodes awcodes commented Dec 9, 2022

Resolves #5131

@what-the-diff
Copy link
Contributor

what-the-diff bot commented Dec 9, 2022 •
edited

  • The mix-manifest.json file was changed to update the hashes of app.js, echo.js and app.css
  • In module/esm/css, a new class called dark was added with some styling for trix-toolbar elements
  • In rich-editor css component, the same changes as in 2 were made but this time using scoped styles instead of global ones (the .dark prefix)

@zepfietje zepfietje added the bug Something isn't working label Dec 10, 2022
@zepfietje zepfietje added this to the v2 milestone Dec 10, 2022
@danharrin danharrin merged commit 237aa41 into 2.x Dec 10, 2022
@danharrin
Copy link
Member

thanks!

@danharrin danharrin deleted the 5131-rich-editor-styles branch December 10, 2022 21:33
@danharrin danharrin mentioned this pull request Dec 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danharrin danharrin Awaiting requested review from danharrin

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.

Rich editor - Link Input text color not readable
3 participants
@awcodes @danharrin @zepfietje