Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Set component inside getAction for repeatable fields #5241

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Fix: Set component inside getAction for repeatable fields #5241

merged 1 commit into from
Dec 13, 2022

Conversation

awcodes
Copy link
Contributor

@awcodes awcodes commented Dec 13, 2022

Updates HasActions trait in forms package to set the component at the action level to fix a bug in repeatable fields where the form component action was returning with the incorrect state path.

@awcodes awcodes added the bug Something isn't working label Dec 13, 2022
@awcodes awcodes added this to the v2 milestone Dec 13, 2022
@awcodes awcodes self-assigned this Dec 13, 2022
@what-the-diff
Copy link
Contributor

what-the-diff bot commented Dec 13, 2022

  • The getAction method was changed to return the action component with a reference to its parent form.

@danharrin danharrin merged commit 0212fdf into 2.x Dec 13, 2022
@danharrin danharrin deleted the fix/form-component-actions-in-repeater branch December 13, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danharrin danharrin Awaiting requested review from danharrin

Assignees

@awcodes awcodes

Labels
bug Something isn't working
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@awcodes @danharrin