Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add DocBlocks to Filament facade #55

Merged
merged 2 commits into from
Mar 2, 2021
Merged

feature: add DocBlocks to Filament facade #55

merged 2 commits into from
Mar 2, 2021

Conversation

ryangjchandler
Copy link
Member

This pull request adds some DocBlock comments to the Filament facade so that IDEs and language servers can provide some decent autocomplete.

I've only added the register* methods for now, since they're more likely to be used than the get* methods.

@danharrin danharrin merged commit b17b4a6 into filamentphp:main Mar 2, 2021
@danharrin danharrin added the enhancement New feature or request label Mar 2, 2021
@danharrin
Copy link
Member

LGTM!

@ryangjchandler ryangjchandler deleted the feature/facade-docblocks branch March 2, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants