New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sort by buttons #5544
Merged
danharrin
merged 12 commits into
filamentphp:2.x
from
bernhardh:feature/sort-by-buttons
Feb 13, 2023
Merged
Feature/sort by buttons #5544
danharrin
merged 12 commits into
filamentphp:2.x
from
bernhardh:feature/sort-by-buttons
Feb 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zepfietje
requested changes
Jan 25, 2023
danharrin
requested changes
Jan 29, 2023
…ature/sort-by-buttons # Conflicts: # packages/forms/config/forms.php # packages/forms/resources/views/components/repeater.blade.php
…ature/sort-by-buttons
All requested changes done. Thank you! |
Any chance, that this PR gets merged soon? |
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, a couple of days ago on discord, this PR reintroduces optionally the up/down buttons for repeater and builder. By default, the buttons are disabled (not shown), so its a none breaking change. If you don't use it, you will not see any change.
To enable just change the config (
forms.components.repeater.up_and_down_buttons
andforms.components.builder.up_and_down_buttons
).When enabled, it will look like this:
Same goes for the builder. In the following example, i Have enabled collapsible and clonable as well, just to see multiple icons: