Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a new method for testing individual search columns #5794

Merged
merged 5 commits into from
Feb 25, 2023
Merged

Adds a new method for testing individual search columns #5794

merged 5 commits into from
Feb 25, 2023

Conversation

joaoprado
Copy link
Contributor

Thank you for this great package. This PR introduces a new method to test individual column search when global search is turned off.

@what-the-diff
Copy link
Contributor

what-the-diff bot commented Feb 25, 2023 •
edited

  • Added searchTableColumns method to the stub file
  • Added a new test for searching individual columns in ColumnTest.php
  • Updated PostsTable class with two more text columns and made them individually searchable

@zepfietje zepfietje added this to the v2 milestone Feb 25, 2023
@zepfietje zepfietje added the enhancement New feature or request label Feb 25, 2023
@danharrin
Copy link
Member

Thanks! Nice feature

@danharrin danharrin merged commit dcb5085 into filamentphp:2.x Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danharrin danharrin danharrin left review comments

@zepfietje zepfietje zepfietje left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joaoprado @danharrin @zepfietje