Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support reactive/lazy modifiers on container components #595

Merged
merged 7 commits into from Sep 19, 2021

Conversation

ryangjchandler
Copy link
Member

This PR will allow container components, e.g. Grid, Section, etc to accept reactive(), lazy() and stateBindingModifiers() calls and then proxy those calls down to child components.

This removes multiple calls to those methods on the child components.

@danharrin
Copy link
Member

I've just refactored this so that the component inherits its state from its container, and the container inherits its state from its parent component, instead of the state being passed down the component tree.

What do you think @ryangjchandler?

@ryangjchandler
Copy link
Member Author

LGTM!

@danharrin danharrin added the enhancement New feature or request label Sep 19, 2021
@danharrin danharrin merged commit de540c8 into 2.x Sep 19, 2021
@danharrin danharrin deleted the feature/state-binding-modifiers-on-all-components branch September 19, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants