Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BelongsToMany with Repeater #6074

Merged
merged 1 commit into from
Mar 31, 2023
Merged

fix: BelongsToMany with Repeater #6074

merged 1 commit into from
Mar 31, 2023

Conversation

danharrin
Copy link
Member

Fixes #5933.

@danharrin danharrin added the bug Something isn't working label Mar 31, 2023
@what-the-diff
Copy link
Contributor

what-the-diff bot commented Mar 31, 2023

PR Summary

  • Added relationship check for BelongsToMany
    A new check has been added to identify if a relationship is of type BelongsToMa. This helps in handling more complex relationships in the code.

  • Improved column selection for join and model's table
    When the relationship is identified as BelongsToMany, the code now selects all columns from both the join table and the model's table, ensuring complete data retrieval.

@danharrin danharrin merged commit 638b613 into 2.x Mar 31, 2023
22 checks passed
@danharrin danharrin deleted the fix/belongs-to-many-repeater branch March 31, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repeater fails silently and pretty badly on BelongsToMany relationship
1 participant
@danharrin