Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown button loading indicator to work with livewire event modifiers #6151

Merged
merged 3 commits into from
Apr 8, 2023
Merged

Fix dropdown button loading indicator to work with livewire event modifiers #6151

merged 3 commits into from
Apr 8, 2023

Conversation

howdu
Copy link
Contributor

@howdu howdu commented Apr 8, 2023

Allow wire:click.stop events to work with dropdown.

@what-the-diff
Copy link
Contributor

what-the-diff bot commented Apr 8, 2023

PR Summary

  • Merging wire:target and wire:click attributes
    The two attributes are combined into a single attribute for better efficiency and easier management.
  • Improved loading indicator target selection
    The loading indicator now prioritizes wire targets or clicks, followed by forms (if available), making the user experience more seamless.

@zepfietje zepfietje added the bug Something isn't working label Apr 8, 2023
@zepfietje zepfietje added this to the v2 milestone Apr 8, 2023
@zepfietje
Copy link
Member

Thanks for the PR, @howdu!
Is this behavior already supported on other components like buttons?

@howdu
Copy link
Contributor Author

howdu commented Apr 8, 2023

No but I've applied this to the other components now too.

@danharrin danharrin merged commit cdd7fbc into filamentphp:2.x Apr 8, 2023
10 checks passed
@howdu howdu deleted the fix-dropdown-button-wire-stop branch April 8, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants