Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added applyEagerLoading and applyRelationshipAggregates to get selected table records #6554

Merged

Conversation

alperenersoy
Copy link
Contributor

@alperenersoy alperenersoy commented May 18, 2023

hey,

when we don't apply relationship aggregates, selected records are being hydrated and passed to actions without aggregates. while adding that, I thought applyEagerLoading is also needed here since we have it for the table query.

I think pipeline failure is not related to the changes. So keeping the PR open.

  • Changes have been thoroughly tested to not break existing functionality.
  • New functionality has been documented or existing documentation has been updated to reflect changes.
  • Visual changes are explained in the PR description using a screenshot/recording of before and after.

@what-the-diff
Copy link
Contributor

what-the-diff bot commented May 18, 2023

PR Summary

  • Improved data loading efficiency
    Added a loop to optimize data loading and better manage relationships between columns.

@danharrin danharrin added the bug Something isn't working label May 20, 2023
@danharrin danharrin merged commit 554693b into filamentphp:2.x May 20, 2023
11 of 12 checks passed
@danharrin
Copy link
Member

Thanks

danharrin added a commit that referenced this pull request May 20, 2023
@henk-n
Copy link

henk-n commented May 20, 2023

Applied the fix manually to check #6492 is solved, and that is the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants