Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use capture #6694

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Use capture #6694

merged 2 commits into from
Jun 5, 2023

Conversation

zepfietje
Copy link
Member

  • Changes have been thoroughly tested to not break existing functionality.
  • New functionality has been documented or existing documentation has been updated to reflect changes.
  • Visual changes are explained in the PR description using a screenshot/recording of before and after.

Stillat/blade-parser-typescript#53 (comment)

@zepfietje zepfietje requested a review from danharrin June 5, 2023 08:21
@zepfietje zepfietje added the chore label Jun 5, 2023
@zepfietje zepfietje added this to the v2 milestone Jun 5, 2023
@what-the-diff
Copy link
Contributor

what-the-diff bot commented Jun 5, 2023

PR Summary

  • Removed ryangjchandler/blade-capture-directive package
    The package is no longer needed in admin composer.json file.
  • Updated Checkbox and Radio components in packages/forms
    These components now use Blade capture directives, improving code organization and readability.
  • Added a new dependency to composer.json
    A new required package has been added for proper functioning.
  • Updated Toggle component in forms package
    The Toggle component now also uses Blade capture directives, resulting in cleaner and more organized code.

@danharrin
Copy link
Member

blade-capture dep needs moving from admin to support

@zepfietje
Copy link
Member Author

Done, @danharrin!

@danharrin danharrin merged commit 831bf79 into 2.x Jun 5, 2023
22 checks passed
@danharrin danharrin deleted the use-capture branch June 5, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants