Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prettier plugin Blade #6699

Merged
merged 6 commits into from
Jun 6, 2023
Merged

Add Prettier plugin Blade #6699

merged 6 commits into from
Jun 6, 2023

Conversation

zepfietje
Copy link
Member

@zepfietje zepfietje commented Jun 5, 2023

I've created a fresh new PR that adds the Blade plugin for Prettier.
CI has run and committed the formatted changes.

I'll be going through the changes and commenting on any remaining issues.
Hopefully we can get this merged into Filament really soon now. 😄

You might also want to take a look at the diff, @danharrin & @JohnathonKoster.

@zepfietje zepfietje added this to the v2 milestone Jun 5, 2023
@what-the-diff
Copy link
Contributor

what-the-diff bot commented Jun 5, 2023

PR Summary

  • Improved code formatting and readability

    • Added prettier-plugin-blade for cleaner blade files
    • Updated .prettierignore rules and fixed issues in the admin package
    • Improved class name readability and consistency
    • Adjusted the order and organization of CSS properties
    • Fixed indentation issues in Blade templates and PHP files
  • Optimized Markup

    • Removed unnecessary whitespace and newlines for consistency and to reduce file size
    • Added missing closing tags and corrected attribute formatting
  • Enhanced Maintenability

    • Changed class order for better readability and consistency
    • Moved Livewire components' classes from class to @class to prevent errors

@zepfietje zepfietje requested a review from danharrin June 5, 2023 15:11
@zepfietje
Copy link
Member Author

Just updated, @JohnathonKoster (#6699 (comment)).

Feel free to review the changes already (it's night here now).

@zepfietje
Copy link
Member Author

@zepfietje Thanks for updating that! I've done a quick look through and things are dramatically better than that first attempt. Do you want me to go through and mark the conversations as resolve as I read through, or just wait for you when its a more reasonable time?

I've just reviewed all changes and haven't found any issues!
Applied some manual tweaks (396b561) and CI is passing now.
I think we (you) did it, @JohnathonKoster! 🙌

@danharrin danharrin merged commit 299e11b into 2.x Jun 6, 2023
22 checks passed
@danharrin danharrin deleted the add-prettier-plugin-blade branch June 6, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants