Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve display table filters #7531

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

antoinemy
Copy link
Contributor

  • Changes have been thoroughly tested to not break existing functionality.
  • New functionality has been documented or existing documentation has been updated to reflect changes.
  • Visual changes are explained in the PR description using a screenshot/recording of before and after.

@what-the-diff
Copy link
Contributor

what-the-diff bot commented Aug 7, 2023

PR Summary

  • Adjustment to Input Item Structure in index.blade.php
    The pull request includes changes to the structure of some items in the index.blade.php. Notably, a wrapper (<x-filament::input.wrapper>) was relocated outside a select item (<x-filament::input.select>).

  • Enhancement of Select Element Interactivity
    An attribute (x-model) was added to the select item, improving its interaction capabilities. This allows the user interface to respond better to user input, leading to an improved user experience.

  • Addition of New Selection Option
    A new selection option has been added to the index.blade.php. Specifically, an option (<option>) with a value of "asc" was added under the select item. This extended selection offers users more choices when interacting with the interface, thus improving functionality.

  • Proper Closure of Select Element
    A closing tag for the select item (</x-filament::input.select>) was included. This fixes any potential issues with code interpretation by ensuring that the select item is correctly closed after the new option item.

@antoinemy
Copy link
Contributor Author

Issue #7510

@danharrin danharrin added the bug Something isn't working label Aug 7, 2023
@danharrin danharrin added this to the v3 milestone Aug 7, 2023
@danharrin danharrin merged commit 38067ec into filamentphp:3.x Aug 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants