Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] [2.x] fix upload progress indicator #7533

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Conversation

coleshirley
Copy link
Contributor

This PR fixes the filepond upload progress indicator not working. This is generally not noticable for small files since uploading is very fast but for large files there is no indication of progress.

image

The livewire $wire.upload() progress callback is not directly compatible with the filepond progress callback. This small callback function makes the two compatible

@what-the-diff
Copy link
Contributor

what-the-diff bot commented Aug 7, 2023

PR Summary

  • Improvement to File Upload Component
    The modification in the file-upload.blade.php file in the forms/resources/views/components directory is an enhancement to the file upload process. We have now added a function that tracks the progress of an ongoing file upload. This function is triggered every time there is an update in the upload process, providing users with live updates and improving the overall user experience.

@coleshirley coleshirley changed the title [bug] fix upload progress indicator [bug] [2.x] fix upload progress indicator Aug 7, 2023
@danharrin danharrin added the bug Something isn't working label Aug 7, 2023
@danharrin danharrin added this to the v3 milestone Aug 7, 2023
@danharrin danharrin merged commit 9177b9c into filamentphp:2.x Aug 7, 2023
@danharrin
Copy link
Member

Thanks!

@danharrin danharrin modified the milestones: v3, v2 Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants