Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hidden label in fieldset #7583

Merged
merged 9 commits into from
Aug 11, 2023
Merged

Support hidden label in fieldset #7583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e16d946
hide fieldset label if hiddenLabel() is called
josefbehr Aug 9, 2023
087613e
wip
zepfietje Aug 9, 2023
8c90bbd
Merge branch '3.x' into bugfix/fieldset-hidden-label
zepfietje Aug 9, 2023
6385d41
Merge branch 'filamentphp:3.x' into bugfix/fieldset-hidden-label
josefbehr Aug 11, 2023
001d5b8
add attribute for hidden label, add sr-only class if it's set
josefbehr Aug 11, 2023
15d89e4
Update fieldset.blade.php
danharrin Aug 11, 2023
ffa31a6
Update fieldset.blade.php
danharrin Aug 11, 2023
59b3259
Update fieldset.blade.php
danharrin Aug 11, 2023
ea2e3ca
Update fieldset.blade.php
danharrin Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/forms/resources/views/components/fieldset.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<x-filament::fieldset
:label="$getLabel()"
:label-hidden="$isLabelHidden()"
:attributes="
\Filament\Support\prepare_inherited_attributes($attributes)
->merge([
Expand Down
1 change: 1 addition & 0 deletions packages/infolists/resources/views/components/fieldset.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<x-filament::fieldset
:label="$getLabel()"
:label-hidden="$isLabelHidden()"
:attributes="
\Filament\Support\prepare_inherited_attributes($attributes)
->merge([
Expand Down
6 changes: 5 additions & 1 deletion packages/support/resources/views/components/fieldset.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
@props([
'label' => null,
'labelHidden' => false,
])

<fieldset
Expand All @@ -10,7 +11,10 @@
}}
>
@if (filled($label))
<legend class="-ms-2 px-2 text-sm font-medium leading-6">
<legend @class([
'-ms-2 px-2 text-sm font-medium leading-6',
'sr-only' => $labelHidden,
])>
{{ $label }}
</legend>
@endif
Expand Down