Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete attribute to password field #7676

Merged
merged 1 commit into from Aug 12, 2023

Conversation

joshbonnick
Copy link
Contributor

This PR adds an autocomplete attribute to the default login form. Previously the form would produce a warning in Chromium browsers due to the lack of an autocomplete attribute.

Warning:
[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq)

  • Changes have been thoroughly tested to not break existing functionality.
  • New functionality has been documented or existing documentation has been updated to reflect changes.
  • Visual changes are explained in the PR description using a screenshot/recording of before and after.

@what-the-diff
Copy link
Contributor

what-the-diff bot commented Aug 11, 2023

PR Summary

  • Enhancement in Login Feature
    Changes in the Login.php file led to an improvement in the user login process. This was achieved by modifying the getPasswordFormComponent method that is responsible for password-related operations during login. Additionally, utilization of a new method autocomplete (set to 'current-password') ensures that the system can recognize and propose the current password to the user, streamlining their login process.

@danharrin danharrin added the enhancement New feature or request label Aug 12, 2023
@danharrin danharrin added this to the v3 milestone Aug 12, 2023
@danharrin danharrin merged commit 3dcee37 into filamentphp:3.x Aug 12, 2023
5 checks passed
@joshbonnick joshbonnick deleted the add_autocomplete branch August 12, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants