Fix table groups only extra column #9362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danharrin
reviewed
Oct 30, 2023
packages/tables/resources/views/components/summary/row.blade.php
Outdated
Show resolved
Hide resolved
danharrin
reviewed
Oct 30, 2023
packages/tables/resources/views/components/summary/index.blade.php
Outdated
Show resolved
Hide resolved
danharrin
reviewed
Oct 30, 2023
packages/tables/resources/views/components/summary/row.blade.php
Outdated
Show resolved
Hide resolved
danharrin
reviewed
Oct 30, 2023
zepfietje
reviewed
Nov 1, 2023
packages/tables/resources/views/components/summary/row.blade.php
Outdated
Show resolved
Hide resolved
zepfietje
reviewed
Nov 1, 2023
zepfietje
reviewed
Nov 1, 2023
| @@ -1069,6 +1070,7 @@ class="fi-ta-record-checkbox" | |||
| :actions="count($actions)" | |||
| :actions-position="$actionsPosition" | |||
| :columns="$columns" | |||
| :group-column="$group?->getColumn()" | |||
There was a problem hiding this comment.
Do we actually need the ? here?
There was a problem hiding this comment.
it should? line 857, 858 is using the ?
There was a problem hiding this comment.
Hmm, in most other places we don't. 🤔
There was a problem hiding this comment.
don't think it matters much tbh
…om/wychoong/filament into fix-table-groups-only-extra-column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9297
when using summary with groups only renders an empty column
this is because when enabled
->groupsOnly, a heading is added to the summary row, so it pushes the columns to the right. and the empty column is from the grouped column