Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import "example" doc text #9483

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Update import "example" doc text #9483

merged 2 commits into from
Nov 6, 2023

Conversation

drbyte
Copy link
Contributor

@drbyte drbyte commented Nov 5, 2023

A couple words were missing from this paragraph.

@drbyte
Copy link
Contributor Author

drbyte commented Nov 5, 2023

Dan, I also wondered about the last line of the doc, which says this:

The current record (if it exists yet) is accessible in $this->record, and the [options](#using-import-options) using $this->options.

I found myself having to "think" about what the word "options" in [options] meant. It took a moment, but then it made sense that it was the "import action form options".
How do you feel about changing the [options] link to [import form options]?
I'm fine with whatever you decide ... just wanted to point it out.

Thanks for all the work that went into this import feature! And its documentation.

@danharrin danharrin added the documentation Improvements or additions to documentation label Nov 6, 2023
@danharrin danharrin added this to the v3.1 milestone Nov 6, 2023
@danharrin
Copy link
Member

Yeah import form options sounds great, thanks!

@drbyte
Copy link
Contributor Author

drbyte commented Nov 6, 2023

Updated.

@danharrin danharrin merged commit 05406a8 into filamentphp:3.1 Nov 6, 2023
4 checks passed
@drbyte drbyte deleted the patch-1 branch November 6, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants