Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fetchFileExistence method to ImageEntry and ImageColumn #9790

Merged
merged 9 commits into from Nov 22, 2023
Merged

Add fetchFileExistence method to ImageEntry and ImageColumn #9790

merged 9 commits into from Nov 22, 2023

Conversation

killjin
Copy link
Contributor

@killjin killjin commented Nov 21, 2023 •
edited

  • Changes have been thoroughly tested to not break existing functionality.
  • New functionality has been documented or existing documentation has been updated to reflect changes.
  • Visual changes are explained in the PR description using a screenshot/recording of before and after.

When I use object storage such as s3, the list is very slow.

@danharrin
Copy link
Member

This needs to be done for the ImageEntry too

Also, I'd probably use the name shouldFetchFileExistence()

@danharrin danharrin added the enhancement New feature or request label Nov 21, 2023
@danharrin danharrin added this to the v3 milestone Nov 21, 2023
danharrin
danharrin requested changes Nov 21, 2023
View reviewed changes
Copy link
Member

@danharrin danharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs docs please

@killjin killjin changed the title ImageColumn shouldQueryExists Add fetchFileExistence method to ImageEntry and ImageColumn Nov 22, 2023
@killjin
Copy link
Contributor Author

killjin commented Nov 22, 2023

Docs added

@danharrin danharrin merged commit 36e80ff into filamentphp:3.x Nov 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danharrin danharrin danharrin requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Roadmap
Archived in project
Milestone
v3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@killjin @danharrin