Fix nested Repeater Eager Loading

[johnwinkcq]

Checks if the relationship is already eagerly loaded, returning itself to avoid querying the database again and causing an N+1 query problem.

Issue/Bug Description: #9776

• Changes have been thoroughly tested to not break existing functionality.
• New functionality has been documented or existing documentation has been updated to reflect changes.
• Visual changes are explained in the PR description using a screenshot/recording of before and after.

[johnwinkcq]

Local composer test:

[danharrin]

Your previous implementation would have broken modifyRelationshipQueryUsing() and orderColumn(). I've added in checks to ensure that this is not used when either of those is set. If you want to use them with eager loading, you must add these clauses to the eager loading itself. Does it still work ok for your use case?

[johnwinkcq]

Your previous implementation would have broken modifyRelationshipQueryUsing() and orderColumn(). I've added in checks to ensure that this is not used when either of those is set. If you want to use them with eager loading, you must add these clauses to the eager loading itself. Does it still work ok for your use case?

would sortBy fix the orderColumn Problem?

elseif (
    $this->getModelInstance()->relationLoaded($relationshipName) &&
    (! $this->modifyRelationshipQueryUsing) &&
    filled($orderColumn)
){
    return $this->cachedExistingRecords = $this->getRecord()->{$relationshipName}->sortBy($orderColumn)->mapWithKeys(
        fn (Model $item): array => ["record-{$item[$relatedKeyName]}" => $item],
    );
}

That would take the eager loading into account & still work, wouldn't it?

[danharrin]

It would fix it, but I don't know why you would want to do that, when you can chain it onto the with() anyway? It's more performant if done on the query instead of the collection

[johnwinkcq]

In my case it does not work.
If I use ->orderColumn() I can sort & save it.
If I use ->reorderable() I can sort it but when I save it, it resets itself. and also a reload of the page shows the status before sorting.

However, I have applied orderBy('sort') directly to the relationship