Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support radio buttons and button group #9860

Merged
merged 21 commits into from Dec 5, 2023

Conversation

zepfietje
Copy link
Member

@zepfietje zepfietje commented Nov 25, 2023

  • Changes have been thoroughly tested to not break existing functionality.
  • New functionality has been documented or existing documentation has been updated to reflect changes.
  • Visual changes are explained in the PR description using a screenshot/recording of before and after.

Buttons (with inline())

Screen.Recording.2023-11-30.at.17.43.14.mov

Button group

Screen.Recording.2023-11-30.at.17.44.49.mov

@zepfietje zepfietje added the enhancement New feature or request label Nov 25, 2023
@zepfietje zepfietje added this to the v3 milestone Nov 25, 2023
@zepfietje zepfietje changed the title Add radio button group API Support radio buttons and button group Nov 30, 2023
@zepfietje zepfietje marked this pull request as ready for review November 30, 2023 18:46
@danharrin danharrin modified the milestones: v3, v3.2 Dec 1, 2023
@zepfietje zepfietje changed the base branch from 3.x to feature-staging December 1, 2023 21:10
@danharrin danharrin merged commit e361051 into feature-staging Dec 5, 2023
9 checks passed
@danharrin danharrin deleted the add-radio-button-group-api branch December 5, 2023 11:53
@faizananwerali
Copy link

is it released or is it going to be released?

@zepfietje
Copy link
Member Author

@faizananwerali
Copy link

@zepfietje but in commits, this is mention in Readme.md file.

Radio::make('status')
    ->buttonGroup()
    ->options([
        'draft' => 'Draft',
        'scheduled' => 'Scheduled',
        'published' => 'Published'
    ])
    ->colors([
        'draft' => 'warning',
        'scheduled' => 'info',
        'published' => 'success',
    ])

I like this because it also supports enum and I've so many Radio buttons in my project that I would have to replace it now wherever I need it. So I'm wondering if there is any reason this was not added or removed after adding because this commit has the code to make this work.

@danharrin
Copy link
Member

The implementation was changed after. It still supports enums

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants