Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manage-issue.yml #9905

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Update manage-issue.yml #9905

merged 2 commits into from
Nov 29, 2023

Conversation

saade
Copy link
Member

@saade saade commented Nov 27, 2023

Url can be null as defined in

const url = urlMatch !== null ? urlMatch[1].trim() : null

Because of that, its causing errors while evaluating NO_REPRO_URL further down in the code, see action log:
https://github.com/filamentphp/filament/actions/runs/7005326321

This PR fixes the evaluation by adding a check wether url is not falsy.

Also fixes the checks for repro urls under filamentphp org to avoid urls like:
#9838

const url = 'https://github.com/filamentphp/demo'

// before
((! url.includes('https://github.com/')) || url.includes('https://github.com/filamentphp/') || url === 'https://github.com/filamentphp') && (! url.includes('https://github.com/filamentphp/demo')) // false

// after
((! url) || (! url.includes('https://github.com/')) || (url.includes('https://github.com/filamentphp'))) // true

@saade saade requested a review from danharrin November 27, 2023 13:55
@danharrin
Copy link
Member

We want to allow filamentphp/demo but deny filamentphp/filament

@danharrin danharrin self-assigned this Nov 27, 2023
@danharrin danharrin merged commit 8b69e72 into 3.x Nov 29, 2023
7 of 9 checks passed
@danharrin danharrin deleted the saade-patch-1 branch November 29, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants