Add option to read entity IDs from standard input #21
Conversation
| */ | ||
| public function getEntityIds( $input ) { | ||
| $entityIds = []; | ||
| while ( $line = fgets( STDIN ) ) { |
There was a problem hiding this comment.
Perhaps it does not fit this interface, though this code make me think yield
There was a problem hiding this comment.
Hm, that would look nice, but I don’t think it’s currently possible here, all the surrounding code expects arrays.
|
The context for this feature request is change 349894 – this feature allows you to automatically import all the entities that the WikibaseQualityConstraints extension needs (see |
lucaswerkmeister
force-pushed
the
stdin
branch
2 times, most recently
from
0c78d97
to
57c6b09
Compare
|
can you please add documentation for the new option in the README ? |
Specifying /dev/stdin as filename does not work on Linux if standard
input is a pipe, since PHP does not open(2) the symlink directly, but
instead follows it using readlink(2), and the Linux kernel returns a
non-filename description for readlink(2) on /proc/[pid]/fd/ entries
corresponding to pipes and sockets (see proc(5)):
readlink("/dev/stdin") -> /proc/self/fd/0
readlink("/proc/self/fd/0") -> pipe:[INODE]
/* ... resolve /proc/self ... */
open("/proc/PID/fd/pipe:[INODE]") -> ENOENT
|
I wasn’t sure what example to use for the pipe, but a simple |
|
@lucaswerkmeister yeah, think either works as an example |
|
Could this perhaps be merged? The option is already used in the WBQC README… |
|
Is there anything blocking this from getting merged? |
|
looks good |
|
Thank you ♥ |
Specifying
/dev/stdinas filename does not work on Linux if standard input is a pipe, since PHP does not open(2) the symlink directly, but instead follows it using readlink(2), and the Linux kernel returns a non-filename description for readlink(2) on/proc/[pid]/fd/entries corresponding to pipes and sockets (see proc(5)):