Declare generic EntityStore as parameter type #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store::getEntityStore() (which is where ImportEntities::newEntityImporter() gets the entity store from) has never promised to return more than a generic EntityStore, and with Wikibase commit 91a07a3901 (change I84661212a6), it has started to return a TypeDispatchingEntityStore instead of a WikiPageEntityStore. As far as I can tell, we don’t need anything specific to WikiPageEntityStore, so adjusting the parameter type should be enough to fix this problem.
|
Looks legit |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store::getEntityStore()(which is whereImportEntities::newEntityImporter()gets the entity store from) has never promised to return more than a genericEntityStore, and with wikimedia/mediawiki-extensions-Wikibase@91a07a3901 (change I84661212a6), it has started to return aTypeDispatchingEntityStoreinstead of aWikiPageEntityStore. As far as I can tell, we don’t need anything specific toWikiPageEntityStore, so adjusting the parameter type should be enough to fix this problem.