Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go back to sending no identifiable User-Agent on POST requests to Nissan #29

Merged
merged 1 commit into from Aug 10, 2021
Merged

Go back to sending no identifiable User-Agent on POST requests to Nissan #29

merged 1 commit into from Aug 10, 2021

Conversation

jmason
Copy link

@jmason jmason commented Jun 1, 2021

This reverts 4005247 , and fixes #28 .

@jmason jmason mentioned this pull request Jun 1, 2021
Closed
@DBMandrake DBMandrake mentioned this pull request Jun 7, 2021
Closed
@anlupat
Copy link

anlupat commented Jun 28, 2021

@filcole please apply this

@jeremycoppey jeremycoppey mentioned this pull request Jul 6, 2021
Closed
@BenWoodford
Copy link

I think to avoid this in the future, the Session class should take a user agent header as an optional constructor argument, which will overrides the User-Agent on a request if it's not null. Then the library doesn't need updating if this happens again, it's jut a quick fix in HASS

@filcole filcole merged commit 129bfd9 into filcole:master Aug 10, 2021
@erlendsellie
Copy link

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User Agent problem again?
5 participants
@jmason @anlupat @BenWoodford @erlendsellie @filcole