Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSpec icons now the same as ruby icons #571

Closed
libbyschuknight opened this issue Mar 22, 2017 · 9 comments
Closed

RSpec icons now the same as ruby icons #571

libbyschuknight opened this issue Mar 22, 2017 · 9 comments
Labels
bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. filetype-support New file-extensions or filename patterns associated with an existing icon. styling Questions and bugs related to package and user stylesheets.

Comments

@libbyschuknight
Copy link

I have just updated this package and all the icons under my spec folder in a Ruby project have changed to the red ruby gem icon. Previously they were the green RSpec icon.

Sorry if this is the wrong place to post this or there is a simply fix but I couldn't find anything about it.

Thanks

@Alhadis
Copy link
Member

Alhadis commented Mar 26, 2017

I swear I wrote a comment on this thread, but it's disappeared.

@libbyschuknight Can you post a screenshot please? I don't know what "RSpec" you're referring to.

@libbyschuknight
Copy link
Author

screen shot 2017-03-27 at 1 26 30 pm

This is a spec file, which is now showing the ruby icon. It use to show a green icon for the spec files, which I think did look a bit different. I can't upload an image of what it was like...

But this:
screen shot 2017-03-27 at 1 31 48 pm
This is what it was like and green.

Found this here https://github.com/file-icons/source/blob/master/charmap.md

😄

@douglascamata
Copy link

This is a recurring issue, I already reported something similar before in #483 and I confirm the same problem happens again with the latest release of this package.

@Alhadis
Copy link
Member

Alhadis commented Mar 27, 2017

I added a new icon for Ruby specs in the latest release:

Problem is, I forgot about specs in nested subdirectories. Meaning test/subdir/a-spec.rb won't show the new icon, but test/a-spec.rb will.

I could fix this, but you all seem so attached to just a plain Ruby icon, so now I don't know what to do.

@libbyschuknight
Copy link
Author

Hey, I'm not attached to the plain Ruby icon! I for one would prefer to have a different icon and colour for the spec files. It was extremely useful to easily see the difference when having lots of files open.
Any reason you can't use the RSpec icon?

And by the way I think file-icons is great! I find it very useful! Thanks for all your hard work on it. 😀

@libbyschuknight
Copy link
Author

Also, I just moved one of my spec files to be in the spec folder and yes it shows that new icon! Yay! I would love it if it could be green instead of red, so it is even more obviously different to a ruby file. I guess I am a sucker for keeping things as is once I discovered I really like something! 😂

@douglascamata
Copy link

I agree with @libbyschuknight. @Alhadis, we are attached to different color between source and spec/test... doesn't need to be the same icon. And the red/green combination was just perfect!

@Alhadis
Copy link
Member

Alhadis commented Mar 30, 2017

This will be resolved in the next release. If you still prefer the test-icon be green, add this to your stylesheet:

.test-ruby-icon::before{
	color: #90a959;
}

And if you prefer the plain old Ruby icon, coloured green:

.test-ruby-icon::before{
	font-family: "Octicons Regular";
	content: "\f047";
	font-size: 16px;
	color: #90a959;
}

@libbyschuknight
Copy link
Author

@Alhadis thank you!

@Alhadis Alhadis added bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. filetype-support New file-extensions or filename patterns associated with an existing icon. styling Questions and bugs related to package and user stylesheets. labels Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. filetype-support New file-extensions or filename patterns associated with an existing icon. styling Questions and bugs related to package and user stylesheets.
Projects
None yet
Development

No branches or pull requests

3 participants