-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSpec icons now the same as ruby icons #571
Comments
I swear I wrote a comment on this thread, but it's disappeared. @libbyschuknight Can you post a screenshot please? I don't know what "RSpec" you're referring to. |
This is a spec file, which is now showing the ruby icon. It use to show a green icon for the spec files, which I think did look a bit different. I can't upload an image of what it was like... But this: Found this here https://github.com/file-icons/source/blob/master/charmap.md 😄 |
This is a recurring issue, I already reported something similar before in #483 and I confirm the same problem happens again with the latest release of this package. |
I added a new icon for Ruby specs in the latest release: Problem is, I forgot about specs in nested subdirectories. Meaning I could fix this, but you all seem so attached to just a plain Ruby icon, so now I don't know what to do. |
Hey, I'm not attached to the plain Ruby icon! I for one would prefer to have a different icon and colour for the spec files. It was extremely useful to easily see the difference when having lots of files open. And by the way I think file-icons is great! I find it very useful! Thanks for all your hard work on it. 😀 |
Also, I just moved one of my spec files to be in the |
I agree with @libbyschuknight. @Alhadis, we are attached to different color between source and spec/test... doesn't need to be the same icon. And the red/green combination was just perfect! |
This will be resolved in the next release. If you still prefer the test-icon be green, add this to your stylesheet: .test-ruby-icon::before{
color: #90a959;
} And if you prefer the plain old Ruby icon, coloured green: .test-ruby-icon::before{
font-family: "Octicons Regular";
content: "\f047";
font-size: 16px;
color: #90a959;
} |
@Alhadis thank you! |
I have just updated this package and all the icons under my spec folder in a Ruby project have changed to the red ruby gem icon. Previously they were the green RSpec icon.
Sorry if this is the wrong place to post this or there is a simply fix but I couldn't find anything about it.
Thanks
The text was updated successfully, but these errors were encountered: