Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cucumber icon is cut off on the left #657

Closed
nikolay opened this issue Oct 12, 2017 · 4 comments
Closed

Cucumber icon is cut off on the left #657

nikolay opened this issue Oct 12, 2017 · 4 comments
Labels
unconfirmed-bug Unreproducible error observed by user, or an unclear bug requiring further investigation. upstream-issue Valid issue, wrong package. Stuff that file-icons has no control or responsibility over.

Comments

@nikolay
Copy link

nikolay commented Oct 12, 2017

For example, .feature files.
@Alhadis
Copy link
Member

Alhadis commented Oct 12, 2017

I've noticed, and you won't believe what's behind this issue. 😞 See atom/atom#15856.

Long story short: I might've uncovered a bug in Chrome.

@nikolay
Copy link
Author

nikolay commented Oct 12, 2017

Thank you, @Alhadis! You are right - it is a Chrome bug, which means, it will take some time to get fixed in Atom, unfortunately. 😞

@Alhadis
Copy link
Member

Alhadis commented Oct 12, 2017

I'd... rather not go through 804 icons to add extra points to "under-detailed" curves, and then manually reimporting each one for all three IcoMoon projects.

But if this gets fixed upstream, the Electron team might be able to cherry-pick a fix...?

@Alhadis
Copy link
Member

Alhadis commented Nov 19, 2017 •
edited

Re-exporting the fonts from IcoMoon seems to have fixed the issue.

Bugs which occur and later fix themselves for no reason seriously piss me off.

@Alhadis Alhadis added bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. unconfirmed-bug Unreproducible error observed by user, or an unclear bug requiring further investigation. upstream-issue Valid issue, wrong package. Stuff that file-icons has no control or responsibility over. and removed bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. labels Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unconfirmed-bug Unreproducible error observed by user, or an unclear bug requiring further investigation. upstream-issue Valid issue, wrong package. Stuff that file-icons has no control or responsibility over.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikolay @Alhadis