Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements #67

Closed
ilanbiala opened this issue Aug 26, 2014 · 15 comments
Closed

Performance improvements #67

ilanbiala opened this issue Aug 26, 2014 · 15 comments
Labels
performance Issues with the package's speed or CPU usage, including startup time.
Milestone

Comments

@ilanbiala
Copy link

The package seems to be quite slow compared to other Atom packages. Is there anything that can be done about performance?

This package added 243ms to startup time.

@DanBrooker
Copy link
Member

That does seem slow, could you screenshot the Timecop package screen?

@ilanbiala
Copy link
Author

screenshot 2014-08-26 18 11 41

This isn't the same load, as evident by the different time.

@DanBrooker
Copy link
Member

I don't think that is a typical load time.
My package load for file-icons is 8ms and activation is 33ms.

Does anyone else have similar load times?

@whitlockjc
Copy link

I see package load of 140ms and package activation of 71ms.

@whitlockjc
Copy link

After restarting the editor, I've reopened a few other projects and I've not see file-icons show up in the list.

@ear1grey
Copy link

ear1grey commented Apr 4, 2016

Currently it takes mine 10x the time of other pieces (OSX 10.11.3 Atom 1.6.2) - is there a debug switch I can flip on?
screenshot 2016-04-04 11 14 06

@Alhadis
Copy link
Member

Alhadis commented Apr 4, 2016

Hrm, really? That's strange, because the package is hardly even taking 19ms to load for me...

19ms

And in Timecop:

@ear1grey
Copy link

I think I've tracked down the culprit - an intermittent DNS fault from my ISP may have been introducing the delay to the startup. Switching to Google's Public DNS (8.8.8.8 / 8.8.4.4) reduces startup to 13ms for me too, so possibly something to look at for async startup in the future, but in the mean time this may help someone.
screenshot 2016-04-11 11 45 17

@Alhadis
Copy link
Member

Alhadis commented Apr 11, 2016

Bizarre. Maybe the metrics package had something to do with it? It might've been trying to report the startup times or something...

@iovis
Copy link

iovis commented Aug 28, 2016

It's taking 578ms to load for me (next one is 57ms). How should I debug this?

@Alhadis
Copy link
Member

Alhadis commented Aug 29, 2016

@iovis9 Is this happening on multiple reboots?

On first load, the package needs to compile the Less sheets if they've changed (which it will if there's been an update released).

(Note this delay won't happen in V2)

@iovis
Copy link

iovis commented Aug 29, 2016

It's been happening over the course of at least 5 months.

@Alhadis
Copy link
Member

Alhadis commented Aug 29, 2016

What other packages do you have installed? Specs, operating system?

@iovis
Copy link

iovis commented Aug 29, 2016

Dammit, I thought this repo was linter-php. I'm having worse problems with them.
A restart of the app now makes it load faster, you're right.

@Alhadis
Copy link
Member

Alhadis commented Aug 29, 2016

Well, that issue won't exist in V2 either way, which uses a config-driven approach instead of a CSS-driven one. :)

@Alhadis Alhadis added the performance Issues with the package's speed or CPU usage, including startup time. label Oct 16, 2018
@Alhadis Alhadis added this to the 2.0.0 milestone Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Issues with the package's speed or CPU usage, including startup time.
Projects
None yet
Development

No branches or pull requests

6 participants